Project

General

Profile

Bug #2348

mdrun can oversubscribe the cores with GPUs, thread-MPI and only -ntomp

Added by Berk Hess almost 2 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
mdrun
Target version:
Affected version - extra info:
any version with GPU sharing
Affected version:
Difficulty:
uncategorized
Close

Description

The code for deciding the number of thread-MPI threads did not (correctly) take into account that the number of OpenMP threads my have been set (by either the user of something in the scheduling). This could lead to oversubscribing the number of hardware threads.
Since in general there is no unique way to decide the number of thread-MPI ranks given the number of OpenMP threads, the number of hardware threads and the number of GPUs, we should not allow to specify -ntomp without -ntmpi.
For the CPU case there is a unique solution, so we do not need to change that (and we should not in a release branch).

Associated revisions

Revision f10d33f1 (diff)
Added by Berk Hess almost 2 years ago

Require -ntmpi with setting -ntomp with GPUs

With GPUs and thread-MPI, setting only -ntomp could lead to
oversubscription of the hardware threads.
Now with GPUs and thread-MPI the user is required to set -ntmpi when
using -ntomp. Here we chose that to also require -ntmpi when the user
specified both -nt and -ntomp; here we could infer the number of
ranks, but it's safer to ask the user to explicity set -ntmpi.
Note that specifying both -ntmpi and -nt has always worked correctly.

Fixes #2348

Change-Id: Iad380721807f5c53b8c70808cea75c5f29341a8f

History

#1 Updated by Gerrit Code Review Bot almost 2 years ago

Gerrit received a related patchset '1' for Issue #2348.
Uploader: Berk Hess ()
Change-Id: gromacs~release-2016~Iad380721807f5c53b8c70808cea75c5f29341a8f
Gerrit URL: https://gerrit.gromacs.org/7337

#2 Updated by Berk Hess almost 2 years ago

  • Status changed from In Progress to Resolved

#3 Updated by Erik Lindahl almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF