Project

General

Profile

Bug #2356

ninja + GMX_BUILD_OWN_FFTW doesn't work

Added by Roland Schulz over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

on WSL with ninja 1.7.2 and cmake 3.5.2. Shouldn't be because of WSL (works fine with make). Given that this is a user feature and they are unlikely t use ninja probably sufficient to print error with ninja.

Associated revisions

Revision e703dde1 (diff)
Added by Roland Schulz over 2 years ago

Update checks for BuildOwnFFT

- Allow on Windows (e.g. WSL, Mingw)
- Disallow with Ninja (broken)

Fixes #2356

Change-Id: I8ac5dd520f92b882dcaeb009792fae2d6e9f0062

History

#1 Updated by Mark Abraham over 2 years ago

ninja + build-own-fftw has worked fine for me on Linux, but haven't explictly tested it lately

#2 Updated by Roland Schulz over 2 years ago

Just checked on Linux. cmake 3.6.3, ninja 1.7.2. Same problem:
ninja: error: 'src/contrib/fftw/fftwBuild-prefix/lib/libfftw3f.a', needed by 'lib/libgromacs.so.3.0.0', missing and no known rule to make it

#3 Updated by Mark Abraham over 2 years ago

Roland Schulz wrote:

Just checked on Linux. cmake 3.6.3, ninja 1.7.2. Same problem:
ninja: error: 'src/contrib/fftw/fftwBuild-prefix/lib/libfftw3f.a', needed by 'lib/libgromacs.so.3.0.0', missing and no known rule to make it

Confirmed on ubuntu 17.10 (cmake 3.9.1, ninja 1.7.2). Happy to just give an error that it won't work, given that few people will use ninja and use the download

#4 Updated by Gerrit Code Review Bot over 2 years ago

Gerrit received a related patchset '1' for Issue #2356.
Uploader: Roland Schulz ()
Change-Id: gromacs~release-2018~I8ac5dd520f92b882dcaeb009792fae2d6e9f0062
Gerrit URL: https://gerrit.gromacs.org/7378

#5 Updated by Roland Schulz over 2 years ago

  • Status changed from New to Resolved

#6 Updated by Erik Lindahl over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF