Project

General

Profile

Bug #2372

gpuAccelerationOfNonbondedIsUseful() prints warning twice

Added by Erik Lindahl over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
mdrun
Target version:
Affected version - extra info:
Affected version:
Difficulty:
simple
Close

Description

The routine always prints the warning, and at least with two thread-mpi ranks the routine is called twice on master.

Associated revisions

Revision 4d26abf1 (diff)
Added by Mark Abraham over 1 year ago

Fix duplicate warning

Thread-MPI, GPUs and energy groups was issuing this warning
twice. Note that no-MPI and real-MPI are still handled correctly -
they warn on the second call, which is the only one made in those
cases.

Fixes #2372

Change-Id: I68eb0505056b8edd5233a6abf1f2e30b09bbacee

History

#1 Updated by Paul Bauer over 1 year ago

Looks like the routine is called once exclusively for master and then once again for all ranks after the initialization of the parallel stuff. I will try to make the second call only for the remaining ranks if this would be acceptable

#2 Updated by Mark Abraham over 1 year ago

i have a fix ready

#3 Updated by Gerrit Code Review Bot over 1 year ago

Gerrit received a related patchset '1' for Issue #2372.
Uploader: Mark Abraham ()
Change-Id: gromacs~release-2018~I68eb0505056b8edd5233a6abf1f2e30b09bbacee
Gerrit URL: https://gerrit.gromacs.org/7420

#4 Updated by Mark Abraham over 1 year ago

  • Category set to mdrun
  • Status changed from New to Fix uploaded
  • Assignee set to Mark Abraham

#5 Updated by Mark Abraham over 1 year ago

  • Status changed from Fix uploaded to Resolved

#6 Updated by Erik Lindahl over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF