Project

General

Profile

Bug #2389

Test don't build with external tinyxml2 version 6

Added by Christoph Junghans almost 2 years ago. Updated about 1 year ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
testing
Target version:
-
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

Found on OpenSuse

[  633s] /home/abuild/rpmbuild/BUILD/gromacs-2016.4/src/testutils/refdata-xml.cpp: In function 'gmx::test::ReferenceDataEntry::EntryPointer gmx::test::readReferenceDataFile(const string&)':
[  633s] /home/abuild/rpmbuild/BUILD/gromacs-2016.4/src/testutils/refdata-xml.cpp:212:33: error: 'class tinyxml2::XMLDocument' has no member named 'GetErrorStr1'; did you mean 'ErrorStr'?
[  633s]          errorString += document.GetErrorStr1();
[  633s]                                  ^~~~~~~~~~~~
[  633s]                                  ErrorStr
[  633s] /home/abuild/rpmbuild/BUILD/gromacs-2016.4/src/testutils/refdata-xml.cpp:213:33: error: 'class tinyxml2::XMLDocument' has no member named 'GetErrorStr2'; did you mean 'ErrorStr'?
[  633s]          errorString += document.GetErrorStr2();
[  633s]                                  ^~~~~~~~~~~~
[  633s]                                  ErrorStr
[  633s] /home/abuild/rpmbuild/BUILD/gromacs-2016.4/src/testutils/refdata-xml.cpp: In function 'void gmx::test::writeReferenceDataFile(const string&, const gmx::test::ReferenceDataEntry&)':
[  633s] /home/abuild/rpmbuild/BUILD/gromacs-2016.4/src/testutils/refdata-xml.cpp:366:54: error: 'XML_NO_ERROR' is not a member of 'tinyxml2'
[  633s]      if (document.SaveFile(path.c_str()) != tinyxml2::XML_NO_ERROR)
[  633s]                                                       ^~~~~~~~~~~~
[  633s] /home/abuild/rpmbuild/BUILD/gromacs-2016.4/src/testutils/refdata-xml.cpp:366:54: note: suggested alternative: 'XML_NO_TEXT_NODE'
[  633s]      if (document.SaveFile(path.c_str()) != tinyxml2::XML_NO_ERROR)
[  633s]                                                       ^~~~~~~~~~~~
[  633s]                                                       XML_NO_TEXT_NODE
[  633s] make[3]: *** [src/testutils/CMakeFiles/testutils.dir/build.make:210: src/testutils/CMakeFiles/testutils.dir/refdata-xml.cpp.o] Error 1
[  633s] make[3]: *** Waiting for unfinished jobs....

suse_build.txt (21.1 MB) suse_build.txt Christoph Junghans, 01/19/2018 08:31 PM

History

#1 Updated by Mark Abraham almost 2 years ago

This library is only used during testing, and not compiled into anything that is installed, so my suggestion is that people don't try to use external versions of it.

#2 Updated by Mark Abraham almost 2 years ago

  • Subject changed from Test don't build with external libxml2 version 6 to Test don't build with external tinyxml2 version 6
  • Target version deleted (2018.1)
  • Affected version changed from 2018 to 2016.4

We bundle tinyxml2 version 3.0.0, and haven't engineered to support linking to external versions that break the API of 3.0.0. So I suggest either linking to external 3.0.0 (or maybe 4 or 5 if they work), or using the bundled version (since it is anyway not needed for what is actually installed - only required for running the tests).

GROMACS version 2018 has the same issue as 2016, but it will be a month or two before I can prioritise fixing it.

#3 Updated by Mark Abraham almost 2 years ago

  • Affected version changed from 2016.4 to 2018

#4 Updated by Mark Abraham about 1 year ago

  • Status changed from New to Rejected

I assume this is no longer a problem! Reopen if there's somethign to work on

Also available in: Atom PDF