Project

General

Profile

Bug #2401

Python scripts use hardcoded #!/usr/bin/python instead of #!/usr/bin/env python

Added by Åke Sandgren over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

The hardcoding of /usr/bin/python makes it overly difficult to point the build to another python installation.
There is also one script, scripts/make_gromos_rtp.py, that has #!/usr/freeware/bin/python

Would be nice to have that fixed. Will also make it easier to migrate to using Python3.


Related issues

Related to GROMACS - Task #1786: Python style standards in developer docsNew2015-07-28

Associated revisions

Revision e6174dd4 (diff)
Added by Mark Abraham over 1 year ago

Use more portable python shebangs

Per https://www.python.org/dev/peps/pep-0394/#recommendation, we
should use env, and point it at python2. When we either make them 2/3
or just-3 compatible, this should change.

Some distros (notable Arch Linux) already point python at python3 so
we should choose to be explicit, and thus somewhat portable.

Fixes #2401

Change-Id: Icf98e04660c798d10b167f971b20698e0741994a

History

#1 Updated by Mark Abraham over 1 year ago

  • Related to Task #1786: Python style standards in developer docs added

#2 Updated by Gerrit Code Review Bot over 1 year ago

Gerrit received a related patchset '1' for Issue #2401.
Uploader: Mark Abraham ()
Change-Id: gromacs~release-2018~Icf98e04660c798d10b167f971b20698e0741994a
Gerrit URL: https://gerrit.gromacs.org/7548

#3 Updated by Mark Abraham over 1 year ago

  • Status changed from New to Resolved

#4 Updated by Mark Abraham about 1 year ago

  • Status changed from Resolved to Closed
  • Target version set to 2018.1

Also available in: Atom PDF