Project

General

Profile

Bug #2509

Gromacs 2018 does not compile on Windows with CUDA

Added by Aleksei Iupinov over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
core library
Target version:
Affected version - extra info:
Affected version:
Difficulty:
simple
Close

Description

Per report on the user list:

C:/tools/GROMACS/gromacs-2018.1/src/gromacs/mdlib/nbnxn_cuda/nvnxn_cuda.cu(646): error: expression must be a modifiable lvalue.

The file nbnxn_cuda.cu in r2018 has 2 places like this:

#if (defined(WIN32) || defined( _WIN32 ))
    /* Windows: force flushing WDDM queue */
    stat = cudaStreamQuery(stream);
#endif

In one of those, stat stopped being declared as a local variable a while ago. This would have been caught half a year ago, if only we had a Windows + CUDA Jenkins config :-)

Associated revisions

Revision 52677c57 (diff)
Added by Aleksei Iupinov over 1 year ago

Remove unused results of cudaStreamQuery()

Coincidentally fixes #2509 (Windows + CUDA compilation)

Change-Id: I032c5fab53bf83cf0ea8c0299d8752b10d1f6c0e

History

#1 Updated by Aleksei Iupinov over 1 year ago

  • Description updated (diff)

#2 Updated by Aleksei Iupinov over 1 year ago

  • Description updated (diff)

#3 Updated by Gerrit Code Review Bot over 1 year ago

Gerrit received a related patchset '1' for Issue #2509.
Uploader: Aleksei Iupinov ()
Change-Id: gromacs~release-2018~I032c5fab53bf83cf0ea8c0299d8752b10d1f6c0e
Gerrit URL: https://gerrit.gromacs.org/7928

#4 Updated by Szilárd Páll over 1 year ago

  • Status changed from New to Fix uploaded

In one of those, stat stopped being declared as a local variable a while ago. This would have been caught half a year ago, if only we had a Windows + CUDA Jenkins config :-)

And we'd have that if the hardline position was not taken a few years ago that if we don't run code we should not build it ;) (e.g. Win/OSX + CUDA)

#5 Updated by Mark Abraham over 1 year ago

Aleksei Iupinov wrote:

Per report on the user list:

C:/tools/GROMACS/gromacs-2018.1/src/gromacs/mdlib/nbnxn_cuda/nvnxn_cuda.cu(646): error: expression must be a modifiable lvalue.

The file nbnxn_cuda.cu in r2018 has 2 places like this:

[...]

In one of those, stat stopped being declared as a local variable a while ago. This would have been caught half a year ago, if only we had a Windows + CUDA Jenkins config :-)

True, but more work than needed for this particular case.

It would have been better if the author and reviewers of https://gerrit.gromacs.org/#/q/I69a6bb59dc8cae18fba539de49c977c0ee814d07,n,z and remembered that we should only use the preprocessor for such things if the code in question cannot compile except under Windows.

#6 Updated by Aleksei Iupinov over 1 year ago

  • Status changed from Fix uploaded to Resolved

#7 Updated by Mark Abraham over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee set to Christoph Junghans

Also available in: Atom PDF