Project

General

Profile

Bug #2583

CUDA host compiler check is not retriggered

Added by Szilárd Páll about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Low
Category:
build system
Target version:
Affected version - extra info:
Affected version:
Difficulty:
uncategorized
Close

Description

The check that is meant to detect whether the nvcc + host compiler combination work correctly seems to not get rerun after conditions change that should otherwise trigger a re-check considering the line source:cmake/gmxManageGPU.cmake#L272.

Repro steps:

$ cmake ../ -DGMX_FFT_LIBRARY=fftpack
[...]
-- Check for working NVCC/C compiler combination
-- Check for working NVCC/C compiler combination - works
[...]

$ cmake ../ -DGMX_FFT_LIBRARY=fftpack -DCUDA_HOST_COMPILER=foo
-- Configuring done
-- Generating done

Clearly, the second cmake invocation should have resulted in a rerun of the check and a failure.


Related issues

Related to GROMACS - Bug #1616: configuration should check that the compiler will work with nvccClosed

Associated revisions

Revision 5a8efa7b (diff)
Added by Szilárd Páll about 1 year ago

Fix nvcc host compiler check triggering

The nvcc host compiler check conditional triggering on the change of the
host compiler binary has not been functional as the check has been
placed after another gmx_check_if_changed() call on the same variable.
This change moves the code that checks the functioning of nvcc and host
compiler to gmxManageNvccConf and refactors the conditionals to reuse
the result of the previously issues check if changed call.

Fixes #2583

Change-Id: I26586aaec394cce93a05774cb4184b3928b560cb

History

#1 Updated by Szilárd Páll about 1 year ago

  • Related to Bug #1616: configuration should check that the compiler will work with nvcc added

#2 Updated by Szilárd Páll about 1 year ago

  • Status changed from New to In Progress

gmx_check_if_changed() on L272 does not work on the CUDA_HOST_COMPILER condition because this is already checked in gmxManageNvccConfig.cmake which precedes this code. In fact, the buggy check in question is also misplaced and as it's an nvcc-specific check, it should be in gmxManageNvccConfig.cmake too.

#3 Updated by Gerrit Code Review Bot about 1 year ago

Gerrit received a related patchset '1' for Issue #2583.
Uploader: Szilárd Páll ()
Change-Id: gromacs~release-2018~I26586aaec394cce93a05774cb4184b3928b560cb
Gerrit URL: https://gerrit.gromacs.org/8110

#4 Updated by Szilárd Páll about 1 year ago

  • Status changed from In Progress to Fix uploaded
  • Assignee set to Szilárd Páll

#5 Updated by Szilárd Páll about 1 year ago

  • Status changed from Fix uploaded to Resolved

#6 Updated by Szilárd Páll about 1 year ago

  • Status changed from Resolved to Closed
  • Target version set to 2018.3

Also available in: Atom PDF