Project

General

Profile

Bug #2591

Log reports incorrect version of hwloc

Added by Kevin Boyd over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
-
Target version:
Affected version - extra info:
Affects all versions
Affected version:
Difficulty:
uncategorized
Close

Description

The reported hwloc versions in the log and "gmx --version" are sometimes older than the version installed. This seems to be because the HWLOC_API_VERSION defined in hwloc.c is only updated when there's a change to the API.

For example, hwloc 2.0.1 shows up as hwloc 2.0.0, hwloc 1.11.10 shows as 1.11.6

Associated revisions

Revision ef6399c6 (diff)
Added by Kevin Boyd over 1 year ago

Report up to date hwloc version information

The hwloc version in gmx --version and log files had been
taken from HWLOC_API_VERSION in the hwloc header, which is
not always updated to reflect new releases.

Added HWLOC_VERSION to buildinfo.h from cmake, used in place of
HWLOC_API_VERSION

Fixes #2591

Change-Id: I0ed9f1f1ad9b4262fbb966c03c407eeb1edfc3da

History

#1 Updated by Szilárd Páll over 1 year ago

This must be present in previous versions too, not only 2019, right? I assume there is an actual hwloc release version available, not just API version?

#2 Updated by Kevin Boyd over 1 year ago

  • Affected version - extra info set to Affects all versions

#3 Updated by Kevin Boyd over 1 year ago

Szilárd Páll wrote:

This must be present in previous versions too, not only 2019, right? I assume there is an actual hwloc release version available, not just API version?

That's correct. Updated the description.

#4 Updated by Kevin Boyd over 1 year ago

Would a reasonable workaround be to have cmake print the found version to config.h and use that?

#5 Updated by Mark Abraham over 1 year ago

Kevin Boyd wrote:

Would a reasonable workaround be to have cmake print the found version to config.h and use that?

src/buildinfo.h.cmakein is a better place. However we can get a version number from the hwloc found by cmake can populate a cmake variable (which might be cache variable only if necessary), that configure_file() will then put into $builddir/src/buildinfo.h

#6 Updated by Kevin Boyd over 1 year ago

  • Assignee set to Kevin Boyd
  • Target version set to 2018.3
  • Affected version changed from 2019 to 2018.2

#7 Updated by Gerrit Code Review Bot over 1 year ago

Gerrit received a related patchset '1' for Issue #2591.
Uploader: Kevin Boyd ()
Change-Id: gromacs~release-2018~I0ed9f1f1ad9b4262fbb966c03c407eeb1edfc3da
Gerrit URL: https://gerrit.gromacs.org/8120

#8 Updated by Kevin Boyd over 1 year ago

  • Status changed from New to Resolved

#9 Updated by Paul Bauer over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF