Project

General

Profile

Task #2684

make sure ARM perf libs for FFTs / BLAS works

Added by Szilárd Páll about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Category:
mdrun
Target version:
Difficulty:
simple
Close

Description

The ARM performance libraries implements FFTs with an FFTW3 compatible API; what's missing is the guru interface, but this is not a hard requirement in our FFT implementation.

For the 2019 release we should make sure that with ARMPL we don't use the guru interface API and that preferably back it with jenkins testing.


Related issues

Related to GROMACS - Task #2685: tweak jenkins post-submit test to use ARMPL for FFTsClosed
Related to GROMACS - Bug #2809: GROMACS 2019 RC1 build fails with GMX_BUILD_OWN_FFTW=ONClosed

Associated revisions

Revision cdffd532 (diff)
Added by Szilárd Páll 12 months ago

Add tweaks to support ARMPL for FFTs

Support added through the FFTW compatibilty layer; the FFTW guru
interface is not implemented in ARMPL, so this is disabled in builds
that use ARMPL. The detection is basic and it is used only for these
purposes, the lirbary and header location needs to be passed manually
(we prefer ARM to implement a Find module).

Fixes #2684

Change-Id: I5afd7c200e2d02ac699bb668d14f0a85bf0a2369

History

#1 Updated by Szilárd Páll about 1 year ago

  • Related to Task #2685: tweak jenkins post-submit test to use ARMPL for FFTs added

#2 Updated by Szilárd Páll about 1 year ago

  • Subject changed from make sure ARM perf libs for FFTs works to make sure ARM perf libs for FFTs / BLAS works

#3 Updated by Szilárd Páll about 1 year ago

  • Target version changed from 2019-beta1 to 2019

#4 Updated by Gerrit Code Review Bot about 1 year ago

Gerrit received a related patchset '2' for Issue #2684.
Uploader: Szilárd Páll ()
Change-Id: gromacs~master~I5afd7c200e2d02ac699bb668d14f0a85bf0a2369
Gerrit URL: https://gerrit.gromacs.org/8557

#5 Updated by Gerrit Code Review Bot about 1 year ago

Gerrit received a related patchset '1' for Issue #2684.
Uploader: Szilárd Páll ()
Change-Id: gromacs~release-2019~I5afd7c200e2d02ac699bb668d14f0a85bf0a2369
Gerrit URL: https://gerrit.gromacs.org/8621

#6 Updated by Szilárd Páll about 1 year ago

  • Target version changed from 2019 to 2019-beta3

I've uploaded the minimal change to be able to link against ARMPL; feedback would be appreciated. Doing more is certainly possible, the question is whether it's worth it.

#7 Updated by Mark Abraham 12 months ago

  • Status changed from In Progress to Fix uploaded

#8 Updated by Paul Bauer 12 months ago

  • Target version changed from 2019-beta3 to 2019-rc1

Bumping to rc1

#9 Updated by Szilárd Páll 12 months ago

  • Status changed from Fix uploaded to Resolved

#10 Updated by Mark Abraham 12 months ago

  • Status changed from Resolved to Closed

#11 Updated by Mark Abraham 11 months ago

  • Related to Bug #2809: GROMACS 2019 RC1 build fails with GMX_BUILD_OWN_FFTW=ON added

Also available in: Atom PDF