Project

General

Profile

Bug #2728

Fix NB kernel picking

Added by Mark Abraham almost 2 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
core library
Target version:
Affected version - extra info:
all versions with verlet scheme support before 2020
Affected version:
Difficulty:
uncategorized
Close

Description

As noted at https://gerrit.gromacs.org/#/c/8200/40/src/gromacs/mdlib/nbnxn_kernels/nbnxn_kernel_common.h@86, there are array entries missing from the CPU kernel tables in nbnxn_kernel_ref.h for kernel flavours that we don't actually use on the CPU, which would be UB. We should either fix that so the array entries are initialized, and that they can't be accessed by such coulkt and vdwkt, or that they fall back to less efficient flavours (if that is possible).

Associated revisions

Revision bf9b602a (diff)
Added by Paul Bauer 8 months ago

Define all CPU NB kernels

Access to kernels that where not defined could otherwise lead to
undefined behaviour.

Fixes #2728

Change-Id: Ib014cfd0dbc46961eb4e6a81acb3e06d57c3df73

History

#1 Updated by Paul Bauer 10 months ago

  • Target version changed from 2020 to 2020.1

#2 Updated by Paul Bauer 8 months ago

  • Status changed from New to Resolved

#3 Updated by Paul Bauer 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF