Project

General

Profile

Feature #2748

Task #2699: Test POWER9

Power9 build system support

Added by Szilárd Páll about 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
build system
Target version:
Difficulty:
uncategorized
Close

Description

The current build system code assumes that if the CPU is not Power7 than it is Power8 and as a result generates compiler flags targeting Power8 also on Power9.

Associated revisions

Revision 2e797c5d (diff)
Added by Mark Abraham 12 months ago

Fix POWER8 and POWER9 build

Tested with GCC 6.4.0 and 8.1.0 in debug and release modes,
with and without SIMD.

xlc is still not supported, e.g. because 16.1 cannot handle an
in-class member initializer list for a C-style array in the same
struct as a member initialized in a constructor initializer
list. Tested for this in the C++11 feature support tests, and we now
issue a descriptive error in this case.

Removed -mdirect-move from POWER8 flags because gcc warns about its
use.

Fixes #2748

Change-Id: I0dc68c12701f041b702063692703cc2e15e96d8e

History

#1 Updated by Szilárd Páll about 1 year ago

#2 Updated by Szilárd Páll about 1 year ago

Also note that gcc8 deprecates the -mdirect-move flag that we explicitly use; I'm not sure how important is it and can't find on how the current set of flags was picked.

#3 Updated by Mark Abraham about 1 year ago

I have WIP that addresses this

#4 Updated by Szilárd Páll about 1 year ago

Mark Abraham wrote:

I have WIP that addresses this

Ack. If you're already at it and you have some docs or info on what's recommended/best, can you please look into why are the current Power8 flags used and whether we should use them?

#5 Updated by Gerrit Code Review Bot about 1 year ago

Gerrit received a related patchset '2' for Issue #2748.
Uploader: Mark Abraham ()
Change-Id: gromacs~release-2019~I0dc68c12701f041b702063692703cc2e15e96d8e
Gerrit URL: https://gerrit.gromacs.org/8717

#6 Updated by Mark Abraham about 1 year ago

  • Parent task set to #2699

#7 Updated by Mark Abraham about 1 year ago

  • Status changed from New to Fix uploaded

#8 Updated by Mark Abraham 12 months ago

  • Status changed from Fix uploaded to Resolved

#9 Updated by Paul Bauer 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF