Project

General

Profile

Bug #2794

Release build fails in PDB2GMX google tests

Added by Paul Bauer 12 months ago. Updated 11 months ago.

Status:
Closed
Priority:
High
Assignee:
Category:
preprocessing (pdb2gmx,grompp)
Target version:
Affected version - extra info:
it is the current head of 2019
Affected version:
Difficulty:
uncategorized
Close

Description

The failed build is here http://jenkins.gromacs.org/view/Release/job/Release_workflow_master/216/

I started bisecting it.


Related issues

Related to GROMACS - Bug #2775: number of ranks reporting was wrongClosed

Associated revisions

Revision 515ea06d (diff)
Added by Mark Abraham 11 months ago

Make only mdrun report process ID

Recent change 367d003106 changed where mdrun reported the process ID,
but in so doing changed various tools to also report the process ID.
This made pdb2gmx tests non-reproducible.

Since the process ID is probably only of minor value to the user, and
probably only of value to users of mdrun, this change adds support for
allowing tools to choose to print the process ID while defaulting to
not reporting it.

Fixes #2794
Refs #2775

Change-Id: Icb6e97d4d7502f12e74cbaa2c1f1a969ba99b917

History

#1 Updated by Paul Bauer 12 months ago

I also added a nightly build for release-2019 to Jenkins, to have testing of the pdb2gmx tests

#2 Updated by Paul Bauer 12 months ago

The issue got introduced in Ifda6c44bfe28628934f4614e20eeeef436d80707 (367d0031064d59ebf7ee650927f4516352be7a38), trying to fix it now.

#3 Updated by Paul Bauer 12 months ago

The change added the Process ID field to the text file output, and this doesn't work with the text matching used to check the pdb2gmx output files. I propose removing this field for the time being again.

#4 Updated by Gerrit Code Review Bot 12 months ago

Gerrit received a related patchset '1' for Issue #2794.
Uploader: Paul Bauer ()
Change-Id: gromacs~release-2019~Icb6c9c687f717d6833db87a588fb57133a456204
Gerrit URL: https://gerrit.gromacs.org/8788

#5 Updated by Paul Bauer 12 months ago

  • Status changed from New to Fix uploaded

#6 Updated by Mark Abraham 11 months ago

  • Related to Bug #2775: number of ranks reporting was wrong added

#7 Updated by Gerrit Code Review Bot 11 months ago

Gerrit received a related patchset '1' for Issue #2794.
Uploader: Mark Abraham ()
Change-Id: gromacs~release-2019~Icb6e97d4d7502f12e74cbaa2c1f1a969ba99b917
Gerrit URL: https://gerrit.gromacs.org/8799

#8 Updated by Mark Abraham 11 months ago

  • Status changed from Fix uploaded to Resolved

#9 Updated by Paul Bauer 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF