Project

General

Profile

Bug #2836

Travis-CI configuration file is broken and obstructive

Added by Eric Irrgang 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Affected version - extra info:
Affected version:
Difficulty:
simple
Close

Description

The Travis-CI configuration file seems to be unused and doesn't work.

It should be updated or removed, but I suggest it should be removed.

Pros:

- Avoid the implication that GROMACS is actively tested on Travis-CI.
- Simplify maintenance of GROMACS forks that maintain their own Travis-CI configuration.

Cons:

- A commit to remove the file may inadvertently remove a modified .travis.yml in a GROMACS fork when updating the fork.
Remediation: retrieve the modified config file from the fork and add it back to the forked repo in a new commit.
- Travis-CI assumes expects the master branch of a repository to have a config file, so forks would need to add a config to their master branch, making it different from the upstream master branch.
Remediation: fork repositories either apply changes to their master branch, use a different name for their default branch, and/or maintain their unaltered copy of Gerrit `master` with a different name.

References:

- https://travis-ci.org/eirrgang/gromacs-gmxapi/builds/478350210
- .travis.yml was added at https://gerrit.gromacs.org/c/4027
- https://travis-ci.org/gromacs/gromacs

Associated revisions

Revision 3f4aeb3b (diff)
Added by Eric Irrgang 10 months ago

Remove .travis.yml Travis-CI config file.

Fixes #2836

Change-Id: Id413c51596dddb230c4b41f4a66673da21322543

History

#1 Updated by Gerrit Code Review Bot 10 months ago

Gerrit received a related patchset '1' for Issue #2836.
Uploader: M. Eric Irrgang ()
Change-Id: gromacs~master~Id413c51596dddb230c4b41f4a66673da21322543
Gerrit URL: https://gerrit.gromacs.org/8998

#2 Updated by Mark Abraham 10 months ago

  • Status changed from New to Resolved

IIRC the original intent was to make it easier for forks to use Travis-CI. If we have a maintainer for it, it can come back, but for now we've removed it.

#3 Updated by Mark Abraham 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF