Feature #3114
Improve GPU update-constraints module
Description
Improve performance, integration and code organization in GPU update-constraints module
Subtasks
Associated revisions
Rename UpdateConstraintsCuda to UpdateConstraintsGpu
This is to folow general naming conventions across the code.
Refs #3114.
Change-Id: Iec3678e1d4152d6442818fcd81020e021927757c
History
#1 Updated by Szilárd Páll over 1 year ago
Suggest splitting things: code quality improvements and performance improvements (unless the former results in the latter) would be best gathered separately. The latter should be a list with an order/prio markings because we want to know what are the low-hanging fruit optimizations that could have impact and may be doable before RC.
#2 Updated by Artem Zhmurov over 1 year ago
- Description updated (diff)
#3 Updated by Artem Zhmurov over 1 year ago
- Description updated (diff)
#4 Updated by Szilárd Páll about 1 year ago
Overlapping H2D of CPU force contributions with GPU force compute seems related, but perhaps doesn't directly belong here, so I'll file a separate redmine.
#5 Updated by Szilárd Páll about 1 year ago
Szilárd Páll wrote:
Overlapping H2D of CPU force contributions with GPU force compute seems related, but perhaps doesn't directly belong here, so I'll file a separate redmine.
Actually, it is rather related to the F buffer ops.
#6 Updated by Artem Zhmurov about 1 year ago
- Description updated (diff)
#7 Updated by Artem Zhmurov 12 months ago
- Subject changed from Possible improvements to update-constraints to Improve GPU update-constraints module
- Target version set to 2021
- Parent task deleted (
#2888)
#8 Updated by Artem Zhmurov 12 months ago
- Description updated (diff)
#9 Updated by Artem Zhmurov 12 months ago
- Tracker changed from Task to Feature
Eliminate D2D copy in update constraints
The intermediate coordinates (x' or xp) are only needed inside
the update-constraints module (for the constraints algorithms)
and never used outside. Hence, the xp variable can be used to
save the coordinates before update, while x stores the final
coordinates. This way, there is no need to make a D2D xp->x
copy after applying the constraints, since x will have the
correct data.
Refs. #2888, #3114.
Change-Id: I363b633976a236a8e2bf2137c21d3bf0a765cb06