Project

General

Profile

Task #906

Merge fatalerror subdirectory into utility

Added by Teemu Murtola over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
core library
Target version:
Difficulty:
uncategorized
Close

Description

Currently, the error handling utilities in src/gromacs/fatalerror/ use string formatting code from src/gromacs/utility/format.h. It's only a matter of time before code in src/gromacs/utility/ will require some error handling support, and that will then introduce a circular dependency between these two directories, which is not desirable. The simplest solution would be to merge the two, as both error handling and general utility functions feel like they should be on the lowest level in the code.

This will be relatively straightforward to do, but there is a non-zero amount of work involved to keep the code well-organized and to update all relevant Doxygen comments, so it would be better to raise any concerns before the work is started.

Associated revisions

Revision 1aa8e394 (diff)
Added by Teemu Murtola over 8 years ago

Merge fatalerror into utility.

Also adjusted a few includes from <...> to "..." in the touched files.

Closes #906, see the issue for details.

Change-Id: I291bfc6a004f6a3b9c3f8c1de8f724320591a5c6

History

#1 Updated by Teemu Murtola over 8 years ago

  • Target version set to 5.0

#2 Updated by Teemu Murtola over 8 years ago

  • Status changed from New to Feedback wanted
  • Assignee set to Teemu Murtola

A patch uploaded to gerrit. There was already a dependency from arrayref.h to gmxassert.h.

#3 Updated by Teemu Murtola over 8 years ago

  • Status changed from Feedback wanted to Closed

Merged.

#4 Updated by Teemu Murtola over 6 years ago

  • Project changed from Source code reorganization to GROMACS
  • Category set to core library

Also available in: Atom PDF