Project

General

Profile

Task #3033

Updated by Eric Irrgang about 1 year ago

There is a little bit of noise left from https://gerrit.gromacs.org/c/gromacs/+/7502 but there is also some house keeping we can do.

Because we have moved to CMake 3.9, we could start using the https://cmake.org/cmake/help/v3.9/module/GoogleTest.html and
https://cmake.org/cmake/help/latest/module/GoogleTest.html#command:gtest_add_tests

We would also like to store a single copy of the googletest source in the repository, but we need to find a good way to use the bundled source when building the @python_packaging/sample_restraint@ tests in the same build tree.

h2. modernizing usage in CMake

0. Reduce use of global CMake variables for tests and test support targets (https://gerrit.gromacs.org/c/gromacs/+/12197)

1. Move custom googletest CMakeLists.txt file out of the way so that we can have a more standard googletest distribution in place.
2. Remove global definitions of variables that are redundant with properties of the gtest and gmock targets.
3. Import missing googletest files that allow for standard definitions of gtest and gmock targets. Replace GROMACS custom targets with standard targets.
4. Migrate consuming targets from variable usage to target dependencies and other modern CMake tools.

Back